Fixes TreeItem minimum width calculations #84186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chybby
force-pushed
the
84015-reveal-entire-long-names
branch
from
984cab3
to
bae0cd4
Compare
1. Adds missing margins to `TreeItem::get_minimum_size`. 2. Sets minimum size dirty flags when an item is (un)collapsed. 3. Fixes depth calculation in `Tree::get_column_minimum_width` that was using the next visible item's depth when calculating the current item's minimum width. Fixes godotengine#84015.
chybby
force-pushed
the
84015-reveal-entire-long-names
branch
from
bae0cd4
to
3c1f1d6
Compare
|
Just checked this was still an issue and synced to head. |
|
Superseded by #91095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TreeItem::get_minimum_size.Tree::get_column_minimum_widththat was using the next visible item's depth when calculating the current item's minimum width.Current:
godot.windows.editor.dev.x86_64_tr8DjP1Rml.mp4
After:
godot.windows.editor.dev.x86_64_xeqjPXrnb0.mp4
Fixes #84015.