Tweak appearance of 3D editor gizmo icons #91174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 7, 2024
Calinou
force-pushed
the
editor-gizmo-icons-tweak-rendering
branch
from
28e6c32 to
9b99ecd
Compare
I've changed the multiplier to 0.6. |
|
Needs a rebase to fix web CI builds. |
- Use alpha scissor to resolve transparency sorting issues with gizmo icons relative to other transparent materials in the scene. This also makes gizmos visible in `screen_texture`, which means gizmos can now be seen through refractive materials. Lastly, this reduces the amount of artifacts visible around gizmo outlines (although they are still present at times). - Make icons darker when not selected to be less intrusive (and easier to distinguish when selected).
Calinou
force-pushed
the
editor-gizmo-icons-tweak-rendering
branch
from
9b99ecd to
e52c9cd
Compare
|
Thanks! |
|
Ooooh just noticed this. It caught me off guard. It will take some getting used to, but I think it is overall a great change |
|
Wow, I literally just noticed that my gizmos were vanishing for this reason today. Thanks for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen_texture, which means gizmos can now be seen through refractive materials. Lastly, this reduces the amount of artifacts visible around gizmo outlines (although they are still present at times).This isn't a perfect solution to all gizmo rendering problems by any means, but it should provide an usability upgrade already.
See Gizmos aren't Z-sorted properly with transparent surfaces #9935
and Node icons in the 3D views have a crusty outline #82579.
Preview
All screenshots/videos performed with a 1920×1080 editor window. At higher resolutions, gizmos look better (both before and after this PR).
All gizmos
The RGB stripes are located behind the gizmos' position, and they use a transparent (Alpha) material.
Selected gizmo comparison
Gizmo visible behind refractive material
Gizmos are still refracted (as they are part of the screen texture), but it's better than nothing.
Transparency sorting
Before (incorrect)
The decal and camera gizmos appear behind the red toruses that are far away in the background, but they shouldn't.
simplescreenrecorder-2024-04-25_20.13.59.mp4
After (correct)
simplescreenrecorder-2024-04-25_20.13.28.mp4