Add adjustments and color correction to Compatibility renderer #91176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #66457
This is the last of the major features missing from the Compatibility renderer. The remaining features are long term projects (e.g. VoxelGI) or things that won't be supported (e.g. SDFGI).
Using adjustments forces using the post processing pass (which is bad for performance on mobile devices). Originally we wanted to implement this in the scene shader and only use the post processing pass with glow. However, the BCS effects are not suitable for multipass lighting. Brightness, saturation and color correction were broken, but acceptable, but contrast completely breaks to a degree that isn't acceptable. I.e. when using contrast any object with multipass lighting has the reverse of the contrast used.