Fix PopupMenu tooltip alignment when scrolling
#91181
Conversation
|
This may need to change if #91997 is merged |
Call xform() on position before passing into PopupMenu::get_tooltip, to undo earlier affine_inverse().xform() call. PopupMenu already adjusts for the control's position when checking which item is selected. Also adjust for PopupMenu's content scale factor to keep tooltips aligned if the scale factor is not 1. Fixes godotengine#91085
aaronp64
force-pushed
the
popup_menu_tooltips
branch
from
09a99fb to
a6802a7
Compare
|
Updated to match the change from #91997, and added scale factor check that was missing in the previous commit. I rebased before amending/force-pushing, not sure if I messed something up with that. The PR shows just the one file changed, but clicking "compare" on the "force-push" message shows a ton of changes - does this look ok? |
There was a problem hiding this comment.
I reproduced the bug in v4.3.rc1.official [e343dbb] and confirm that this PR fixes it.
I'm not super familiar with the functions being called but the added code look solid enough. Even though it is in Viewport, I think regression risk is small because the change is very local.
I'm not sure what's up with the compare link in the force push, but I'm guessing it's ok since "files changed" includes the scale factor check.
Call
xform()on position before passing intoPopupMenu::get_tooltip, to undo earlieraffine_inverse().xform()call.PopupMenualready adjusts for the control's position when checking which item is selected. Also adjust forPopupMenu's content scale factor to keep tooltips aligned if the scale factor is not 1.Fixes #91085.
Bugsquad edited: Supersedes #90922.