Fix tooltip mouse position conversion for scaled controls #91997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewport used get_global_transform().xform_inv(mpos) to convert the mouse position to the control's local coordinates when getting the control's tooltip, which does not handle scale correctly. This impacted tooltips for any controls that depended on the position to determine what tooltip to show, including RichTextLabel, ItemList, Tree, and probably some others. This change is for Viewport to use get_global_transform_with_canvas().affine_inverse().xform(mpos) for tooltips instead, to match what we do for Viewport::_gui_call_input. Fixes godotengine#91984
Calinou
added
bug
topic:gui
cherrypick:4.2
|
Hey can this be looked at again? |
|
Bump |
Calinou
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
Testing project: RichTextLabelHintTestGdscript.zip
(This is the MRP from #91984 converted to GDScript, so you don't need a C# build to run it.)
Before
tooltip_before.mp4
After (this PR)
tooltip_after.mp4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewportusedget_global_transform().xform_inv(mpos)to convert the mouse position to the control's local coordinates when getting the control's tooltip, which does not handle scale correctly. This impacted tooltips for any controls that depended on the position to determine what tooltip to show, includingRichTextLabel,ItemList,Tree, and probably some others. This change is forViewportto useget_global_transform_with_canvas().affine_inverse().xform(mpos)for tooltips instead, to match what we do forViewport::_gui_call_input.Fixes #91984