Fix reparenting after hover delay

[AeioMuch]

Fix #91254
Also keep all nodes selected after reparenting and not just top level ones (before hover delay, because after it's the hovered/inspected node that should be the one selected)

[Hilderin]

Seems to work perfectly. Thanks!
The only difference with before is that when hovered the rectangle around the node is gone. I think it's brilliant because the rectangle around the node was interfering with the "drop line" making it difficult to see.

[ajreckof]

One thing that makes me ticks is that the bug was supposedly introduced by #90653 but this fix does not touch code related. This might still be the proper fix but ask the question on why it does not implicate the code that broke it. I'll try to take a look when I have time most likely sometime between monday and tuesday.

[AeioMuch]

Hello 👋

Seems to work perfectly. Thanks! The only difference with before is that when hovered the rectangle around the node is gone. I think it's brilliant because the rectangle around the node was interfering with the "drop line" making it difficult to see.

Thanks for your test and feedback!

One thing that makes me ticks is that the bug was supposedly introduced by #90653 but this fix does not touch code related. This might still be the proper fix but ask the question on why it does not implicate the code that broke it. I'll try to take a look when I have time most likely sometime between monday and tuesday.

The way I was ensuring that the inspected/hovered Node/TreeItem got selected and added to history when the drag ended was by using scene_tree->set_selected(node_hovered_now);, but since the changes in your PR apparently, it look like it update while the drag is happening or something, causing the issue. Just preventing the signal to be emited by passing false scene_tree->set_selected(node_hovered_now, false); avoided the issue, but then the problem was that it was not added to the editor selection history anymore after, so I did it when the drag end notification happen instead. I don't think that your PR is problematic per se, just that it changed the previous behaviour which I was relying on initially, but would be better if you can check that there's not more to it indeed.

While I was at it, I removed the use of the marked property and directly changed the text color to accent color which visually achieve the same result, with the bonus that it does not lose the accent outline around the target node for the reparent. set_marked is forcing the tree to update, causing it to lose the outline, and since now they stay visible I felt it was also better to not set the cursor on TreeItem because that gray outline was overlapping the other, as pointed by @Hilderin ... 😅

Anyway, if you can take a look at it when you have the time that would be greatly appreciated ! If you think you need to superseed (I think that's the term) it to make some more in depth changes, no problem, or if I need to make more corrections, let me know 👍.

Thanks a lot !

[AeioMuch]

Retested this, and realized this approach still have issue with the path(s) used in the history when reparenting.

EDIT : The issue had nothing to do with this fix

[AThousandShips]

See also:

• Fix no reparent after hover and no move. #91439
• Fix scene tree selection #91430

[KoBeWi]

The changes look fine. There is a minor issue where the inspected node does not appear at the top, but it can be fixed later:

godot.windows.editor.dev.x86_64_HVzun4zCyh.mp4

[AeioMuch]

The changes look fine. There is a minor issue where the inspected node does not appear at the top, but it can be fixed later:

godot.windows.editor.dev.x86_64_HVzun4zCyh.mp4

Yes indeed, right now it will do it only once the drag is ended. Tho I've realized another small issue caused with those new changes is that if you inspect a node by hovering it, then while dragging towards the inspector you somehow pass the mouse over another node it would not select the inspected node at the end of the drag but the last one hovered instead, so I've made another small change : instead of selecting the node_hovered_now at the end of the drag, I select the edited object in the inspector which should be the one selected at the end of the drag in this case.

[ajreckof]

This looks really good! There is a problem with selection history but this can be fixed later as it is non blocking and only slightly related

[ajreckof]

why is this needed? I'm wondering as this might make #91860 resurface

[AeioMuch]

In this case it is for consistency so that when you reparent using the right click option Reparent it also keep all the reparented nodes selected. I will test with the fix for the issue you pointed to make sure it does not brake it again, if it does tho I will just remove that for now since it is not that important

EDIT : Tested with the fix and it does not make the issue you've mentionned resurface

[akien-mga]

Thanks!