Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web IME] Fix suggestion window position in Chromium based browsers. #91695

Merged
merged 1 commit into from
May 28, 2024
Merged

[Web IME] Fix suggestion window position in Chromium based browsers. #91695

merged 1 commit into from
May 28, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented May 8, 2024 •
edited
Loading

  • Adds canvas to parent coordinate transform (fixes IME window position on HiDPI / zoomed canvas).
  • Sets IME input element size / font size / text alignment to be big enough for a lot of text (Chromium take it into account when calculating IME window position).
  • Fixes text being added to incorrect control if you switch focus while IME suggesting window is active.

Fixes #91204

@bruvzg bruvzg added this to the 4.3 milestone May 8, 2024
@bruvzg bruvzg mentioned this pull request May 9, 2024
Merged
@bruvzg bruvzg marked this pull request as ready for review May 9, 2024 06:41
@bruvzg bruvzg requested a review from a team as a code owner May 9, 2024 06:41
@akien-mga akien-mga merged commit ac6f578 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:input topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

TextEdit or LineEdit cannot input Chinese characters on the web
2 participants
@bruvzg @akien-mga