Display custom data name instead of indices in TileData inspector #92322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 24, 2024
groud
force-pushed
the
implement_custom_data_label
branch
from
9a00cf3 to
6f6a20b
Compare
|
Hmm, not sure what I can do about the CI error, I already added the compatibility method. Do I need to do something else? Or should I just add the errors to the list of expected changes? In |
|
You still need to add the line to the compat file yep |
akien-mga
reviewed
May 24, 2024
akien-mga
reviewed
May 24, 2024
groud
force-pushed
the
implement_custom_data_label
branch
from
6f6a20b to
a02b23c
Compare
groud
force-pushed
the
implement_custom_data_label
branch
from
a02b23c to
f9dff6a
Compare
KoBeWi
reviewed
May 25, 2024
KoBeWi
reviewed
May 25, 2024
KoBeWi
reviewed
May 25, 2024
KoBeWi
approved these changes
May 25, 2024
groud
force-pushed
the
implement_custom_data_label
branch
2 times, most recently
from
9964546 to
cf2ff18
Compare
AThousandShips
approved these changes
May 25, 2024
groud
force-pushed
the
implement_custom_data_label
branch
from
cf2ff18 to
85eac45
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #66853
Closes #92149
Closes #76733