Skip to content

[macOS] Improve native menu open/close callbacks. #92781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2024
Merged

[macOS] Improve native menu open/close callbacks. #92781

merged 1 commit into from
Jun 7, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 5, 2024 •
edited
Loading

  • Fixes OSX MenuBar fails to render #91855 (comment) (Can't remove open menu! messages when dock menu is updated in a specific conditions).
  • Deffer menu close callback, since it should not be able to modify menu items during system menuDidClose event.
  • Adds is_opened to check if menu is opened, since open callback can be triggered without corresponding close callback.

Fixes #92789

@bruvzg bruvzg added this to the 4.3 milestone Jun 5, 2024
@bruvzg bruvzg requested review from a team as code owners June 5, 2024 07:38
@bruvzg bruvzg mentioned this pull request Jun 5, 2024
Closed
akien-mga
akien-mga reviewed Jun 5, 2024
View reviewed changes
@bruvzg bruvzg force-pushed the menu_open_close_imp branch from 23b5034 to 1f7bf27 Compare June 5, 2024 17:23
@akien-mga akien-mga merged commit ea7d988 into godotengine:master Jun 7, 2024
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement platform:macos topic:gui topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Error "Can't remove open menu!" when closing and opening scenes in editor on macOS OSX MenuBar fails to render
2 participants
@bruvzg @akien-mga