Update Camera2D gizmos when screen size changes #92992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Jun 10, 2024
KoBeWi
force-pushed
the
buy_a_new_camera_every_time_project_settings_change
branch
from
d8134f5
to
3376f67
Compare
Calinou
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
If the project_settings_changed signal had an array of modified setting names, we could be more selective on this, but it'll do for now. This is effectively an editor-only change anyway, so runtime performance is unaffected.
KoBeWi
force-pushed
the
buy_a_new_camera_every_time_project_settings_change
branch
from
3376f67
to
9f7f180
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92976
Technically it causes unnecessary redraws when other settings change, but it's not really a problem.