Update canvas layer size and control after project settings changed. #93717
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we make this editor-only, it should be fine. This is what we did for Camera2D: #92992 |
Calinou
reviewed
Jun 28, 2024
Calinou
reviewed
Jun 28, 2024
In `canvas_item_editor_plugin`: Call `update_viewport()` in `_project_setting_changed` to redraw viewport after project settings changed. In `control`: Add a new private function `_project_setting_changed` to update the size and redraw the control. Connect/Disconnet this function to "settings_changed" of `ProjectSettings` when the control enters/exits the canvas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69208
update_project_settings.mp4
In
canvas_item_editor_plugin: Callupdate_viewport()in_project_setting_changedto redraw viewport after project settings changed.In
control: Add a new private function_project_settings_changedto update the size and redraw the control. Connect/Disconnect this function to "settings_changed" ofProjectSettingswhen the control enters/exits the canvas.NOTE 0: The signal name used here is string literal, but some other names are wrapped by
SNAMEorSceneStringName. Not sure if we have to make any modifications to keep consistency.NOTE 1: I'm a bit worried about the performance here. We use "settings_changed" signal here, so any change unrelated to viewport will also trigger a redraw. Should the signal be more fine-grained?