Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in visual shader varyings #93219

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix bugs in visual shader varyings #93219

merged 1 commit into from
Jun 17, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jun 16, 2024 •
edited
Loading

  • Hides the "Varyings" property tab from the inspector - it should be internal and changed via the visual shader graph setters
  • And fixes the following incorrect behavior :

vs_bug

Which caused because two or more shaders are overrides the varying data in class (fixed by using a RID of shader for RBMap to store the varying data similar to VisualShaderNodeParameterRef now).

@Chaosus Chaosus requested a review from a team as a code owner June 16, 2024 07:17
@Chaosus Chaosus added this to the 4.3 milestone Jun 16, 2024
@Chaosus Chaosus changed the title Fix varying names breaking visual shader Fix varying names/preview breaking visual shader Jun 16, 2024
@Chaosus Chaosus mentioned this pull request Jun 16, 2024
Closed
@Chaosus Chaosus force-pushed the vs_fix_varyings branch 2 times, most recently from e48c2ba to d44659d Compare June 16, 2024 13:23
@Chaosus Chaosus changed the title Fix varying names/preview breaking visual shader Fix bugs in visual shader varyings Jun 16, 2024
@Chaosus Chaosus force-pushed the vs_fix_varyings branch 2 times, most recently from 3b8b3f0 to 8bd6931 Compare June 16, 2024 13:50
@akien-mga akien-mga merged commit 170af05 into godotengine:master Jun 17, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_fix_varyings branch June 17, 2024 11:31
paddy-exe
paddy-exe approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Haven't tested it yet though. Just now saw the merge notification 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
bug topic:shaders
Projects
None yet
Milestone
4.3
3 participants
@Chaosus @akien-mga @paddy-exe