-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent generating preview for zero sized texture #93255
Merged
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
atlas-default
branch
from
June 17, 2024 04:58
7ee90b8
to
858c629
Compare
I'm not sure that's a good idea, given this: int AtlasTexture::get_width() const {
if (region.size.width == 0) {
if (atlas.is_valid()) {
return atlas->get_width();
}
return 1;
} else {
return region.size.width + margin.size.width;
}
}
int AtlasTexture::get_height() const {
if (region.size.height == 0) {
if (atlas.is_valid()) {
return atlas->get_height();
}
return 1;
} else {
return region.size.height + margin.size.height;
}
} It seems like it's expected that a region of size 0 will fall back to the full size atlas. |
I just had another idea of fixing this bug ! |
jsjtxietian
changed the title
Make AtlasTexture's region default to (1,1)
Prevent generating preview for zero sized texture
Jun 18, 2024
jsjtxietian
force-pushed
the
atlas-default
branch
from
June 18, 2024 03:07
858c629
to
2a94db7
Compare
clayjohn
reviewed
Jun 18, 2024
jsjtxietian
force-pushed
the
atlas-default
branch
from
June 18, 2024 04:09
2a94db7
to
311c0ec
Compare
jsjtxietian
force-pushed
the
atlas-default
branch
from
June 18, 2024 08:04
311c0ec
to
3027b49
Compare
Mickeon
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the more sensible solution to me
akien-mga
approved these changes
Jun 18, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93151