Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset when disabling override pose in BoneAttachment3D #93482

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Reset when disabling override pose in BoneAttachment3D #93482

merged 1 commit into from
Jun 28, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jun 22, 2024 •
edited
Loading

bone_global_pose_override has been deprecated and is no longer used, so the explicit reset is required here instead.

@TokageItLab TokageItLab added this to the 4.3 milestone Jun 22, 2024
@TokageItLab TokageItLab requested a review from a team June 22, 2024 19:32
@TokageItLab TokageItLab requested a review from a team as a code owner June 22, 2024 19:32
@fire fire requested a review from a team June 27, 2024 15:44
@akien-mga akien-mga merged commit 11db60e into godotengine:master Jun 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the reset-attachment branch June 29, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Disabling override pose on BoneAttachment3D didn't reset the selected bone's pose in skeleton
3 participants
@TokageItLab @akien-mga @fire