Fix default collision shape on imported rigidbody #93506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
fix_import_rigidbody
branch
from
9b19bb7
to
ab0c974
Compare
|
Adjusted this so our default mode is "automatic" after a suggestion @Calinou made. This way we have our backwards compatibility in tact without needing to do weird interface changes |
fire
requested changes
Jun 27, 2024
clayjohn
approved these changes
Jun 27, 2024
fire
approved these changes
Jun 27, 2024
AThousandShips
approved these changes
Jun 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @reduz , the functionality he was under the impression of existing was that we would use Trimesh as the default for static colliders, and Decompose Convex for dynamic colliders.
This does not seem to be applied.
This PR fixes the automatic creation of the collision shape if no value was saved to
shape_type, however it does not embed the logic of changing it properly when you select the right option from the dropdown. Need some guidance on how this can be made to work in the UI here.