Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Add "threads"/"nothreads" feature tags to export presets #93556

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jun 24, 2024

This allows selecting threads/nothreads gdextensions at export time (see godotengine/godot-cpp#1451).

As per my comment (godotengine/godot-cpp#1451 (comment)) it would be nice to provide also a nothreads feature flag to avoid relying on ordering in the gdextension file (and improve detection when using auto prefix).

See Faless@a17b075 for the relevant changes (happy to attach them to this PR).

@Faless Faless added this to the 4.3 milestone Jun 24, 2024
@Faless Faless requested a review from a team as a code owner June 24, 2024 15:01
@akien-mga
Copy link
Member

As per my comment (godotengine/godot-cpp#1451 (comment)) it would be nice to provide also a nothreads feature flag to avoid relying on ordering in the gdextension file (and improve detection when using auto prefix).

See Faless@a17b075 for the relevant changes (happy to attach them to this PR).

I think that makes sense to add.

@fire

This comment was marked as outdated.

@Faless
Copy link
Collaborator Author

Faless commented Jun 24, 2024

In common style we prefer positive names over negative names like nothreads.
Maybe singlethread? I am not picky.

nothreads was chosen for the binary name in #85939 , we should stay consistent with that if possible.

@mihe
Copy link
Contributor

mihe commented Jun 24, 2024

I went ahead and made a PR for a nothreads feature tag: #93563

@akien-mga
Copy link
Member

Can be rebased on top of #93563 to add the Web exporter counterpart.

Following the "variant/thread_support" preset option.
@Faless Faless force-pushed the web/fix_threads_features branch from e805250 to f59c1f0 Compare June 25, 2024 09:45
@Faless Faless changed the title [Web] Add "threads" feature tag according to preset "variant" option [Web] Add "threads"/"nothreads" feature tags to export presets Jun 25, 2024
@Faless
Copy link
Collaborator Author

Faless commented Jun 25, 2024

Can be rebased on top of #93563 to add the Web exporter counterpart.

Done

@akien-mga akien-mga merged commit 2161f98 into godotengine:master Jun 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the web/fix_threads_features branch June 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants