-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Add "threads"/"nothreads" feature tags to export presets #93556
Conversation
I think that makes sense to add. |
This comment was marked as outdated.
This comment was marked as outdated.
|
I went ahead and made a PR for a |
Can be rebased on top of #93563 to add the Web exporter counterpart. |
Following the "variant/thread_support" preset option.
e805250
to
f59c1f0
Compare
Done |
Thanks! |
This allows selecting threads/nothreads gdextensions at export time (see godotengine/godot-cpp#1451).
As per my comment (godotengine/godot-cpp#1451 (comment)) it would be nice to provide also a
nothreads
feature flag to avoid relying on ordering in thegdextension
file (and improve detection when using auto prefix).See Faless@a17b075 for the relevant changes (happy to attach them to this PR).