Add Web header to quickly debug the type of an export #94072
Conversation
adamscott
force-pushed
the
print-web-release-version
branch
from
29a98a9 to
552e914
Compare
| if (p_feature == "web_extensions") { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
I wonder if this should be a generic gdextension feature instead, so that it can be enabled on all platforms that support GDExtension at build-time.
If we decide to keep the web_ prefix, then it should be web_gdextension, similar to web_macos, web_ios and so on.
There was a problem hiding this comment.
I think it could make sense to have a generic gdextension feature, if also have GDEXTENSION_ENABLED (or NOGDEXTENSION) flag to enable/disable the GDExtension code (though I'm not sure if it's worth it).
In case, we might want to add the feature flag to the export plugin too like done in #93556
There was a problem hiding this comment.
@Faless I'm wondering how we can do this properly. Like, for the web, gdextension could be disabled, but with the dlink enabled. Yes, we could remove the dlink setting to bind it with the gdextension value, but gdextension off would be the equivalent of telling the export "don't export any shared objects", isn't it?
adamscott
force-pushed
the
print-web-release-version
branch
from
552e914 to
b41d625
Compare
adamscott
force-pushed
the
print-web-release-version
branch
from
b41d625 to
9ad3f87
Compare
This PR adds "web_extensions" to
OS.has_feature().It also add an header to the boot sequence of the Web build in order to quickly discriminate which features are enabled for that export.