Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some TileMapLayer editing problems #93747

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 29, 2024

Follow-up to #92016

  • fixes error spam when TileMapLayer has no TileSet (regression)
  • fixes the dragging bug mentioned in the previous PR

@KoBeWi KoBeWi added this to the 4.3 milestone Jun 29, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner June 29, 2024 16:20
@akien-mga akien-mga merged commit 4ab8fb8 into godotengine:master Jun 29, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the layer_of_bugs branch June 29, 2024 18:08
@Macksaur
Copy link
Contributor

Macksaur commented Jul 2, 2024

This PR breaks right click to erase (line/rect).

@@ -763,9 +763,13 @@ bool TileMapLayerEditorTilesPlugin::forward_canvas_gui_input(const Ref<InputEven
}

} else {
// Released
_stop_dragging();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above _stop_dragging() call relies on the state of drag_erasing for selecting patterns when right clicking.

@KoBeWi KoBeWi mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants