Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RMB erasing of tiles #93850

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix RMB erasing of tiles #93850

merged 1 commit into from
Jul 2, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 2, 2024

@KoBeWi KoBeWi added this to the 4.3 milestone Jul 2, 2024
KoBeWi
KoBeWi commented Jul 2, 2024
View reviewed changes
editor/plugins/tiles/tile_map_layer_editor.cpp
if (drag_type == DRAG_TYPE_NONE) {
drag_erasing = false;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not needed, but to be sure...

groud
groud approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well, having a quick look at the previous PR I was wondering if the order mattered. I assumed it didn't, but well, I guess I was wrong. This fix looks good.

@akien-mga akien-mga merged commit bd5eab9 into godotengine:master Jul 2, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud groud approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @akien-mga @groud