RenderingDevice: Leave handling of compressed block granularity to the driver #94069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following Vulkan validation error in
command_copy_texture_to_buffer()
:The issue is that Vulkan expects the dimensions be passed there without stepifying to the block size.
This PR changes the implicit contract between
RenderingDevice
andRenderingDeviceDriver
so drivers now have to be aware that they will get logical sizes and they have to perform the rounding to physical block size according to what the underlying graphics API expects. That's OK for Vulkan, for obvious reasons, and also fine for Direct3D 12 becauseRenderingDeviceDriverD3D12
performs the rounding itself so it doesn' really care. I'd just like to let @stuartcarnie know so he can adapt the Metal RDD to this "spec" change.