Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio stream being considered as playing after it has ended #94269

Closed
wants to merge 1 commit into from
Closed

Fix audio stream being considered as playing after it has ended #94269

wants to merge 1 commit into from

Conversation

anniryynanen
Copy link
Contributor

Fixes #94229.

@anniryynanen anniryynanen requested a review from a team as a code owner July 12, 2024 14:55
@anniryynanen anniryynanen mentioned this pull request Jul 12, 2024
Closed
@anniryynanen
Copy link
Contributor Author

This is probably not needed after #94268?

@adamscott
Copy link
Member

@anniryynanen I think #94268 and #94229 aren't related at all.

@Chaosus Chaosus added this to the 4.3 milestone Jul 12, 2024
@adamscott
Copy link
Member

I don't think this is the solution, as this seems to bypass the current system of determining if a stream is up or down.

I found the problem, but I think it's maybe because it was built this way intentionally. I need to investigate.

@anniryynanen anniryynanen deleted the audio-stream-playing branch July 12, 2024 15:25
@AThousandShips AThousandShips removed this from the 4.3 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug platform:web topic:audio topic:porting
Projects
None yet
Milestone
No milestone
4 participants
@anniryynanen @adamscott @Chaosus @AThousandShips