Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Expose missing default properties, ensure bbcode is reparserd when these are changed. #94426

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 16, 2024

For whatever reason, default alignment and some other properties were not accessible. As well as not fully applied to the bbcode and not fully updated when changed.

@bruvzg bruvzg added this to the 4.x milestone Jul 16, 2024
@bruvzg bruvzg requested review from a team as code owners July 16, 2024 08:39
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 607b230), it works as expected.

Testing project: test-richtextlabel-default-align.zip

BBCode surrounding the whole text on the left, default horizontal alignment properties on the right
image

This is a more general comment that would need to be addressed in a separate PR for nodes such as Label as well, but the inspector is now quite long when all sections are collapsed. It might be worth moving Justification Flags (and perhaps Tab Size and Tab Stops) to its own section that could be collapsed (since it doesn't need to be tweaked often):

image

@akien-mga
Copy link
Member

@bruvzg Couple review comments to handle, then it should be good to merge.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 28, 2024
@akien-mga akien-mga merged commit f1cb4cb into godotengine:master Aug 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add horizontal_alignment property for RichTextLabel
4 participants