[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st regressions batch #929

Spartan322 · 2025-01-17T21:27:58Z

Depends on [4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st crashes batch #928

Regression PRs:

Autocompletion: Keep get_node values which are compatible with type hint godotengine/godot#92263
Improve blend tree contrast/margins godotengine/godot#94721
Don't fold resources when child of main inspector exits godotengine/godot#95149
Fix InputMap::event_get_index to handle unmatched events correctly godotengine/godot#95750
Fix Inspector may scroll away when editing a property that adds or removes sub properties godotengine/godot#96542
Fix EditorSpinSlider blocking viewport from getting focus godotengine/godot#96786
Fix RichTextLabel's modified stack being wiped on translation changes godotengine/godot#97061
Add forgotten get_space() check in GodotArea3D::remove_soft_body_from_query() godotengine/godot#97130
Fix Undo/Redo not working in Bezier Animation Editor when moving keys godotengine/godot#97169
Fix TabBar initialization issue and add tests godotengine/godot#97255
Fix crash when importing a surface with no UVs after another surface in the same OBJ file that had UVs godotengine/godot#97264
Fix physics platform behaviour regression godotengine/godot#97315
Clean up two recently introduced WebGL errors godotengine/godot#97379
Fix editing of some properties in CodeHighlighter godotengine/godot#97414
Fix ItemList text trimming godotengine/godot#97439
Fix renaming nodes on X11 godotengine/godot#97447
GDScript: Fix GDScriptCache::get_full_script() uses non-remapped path godotengine/godot#97769
[GraphEdit] Only print warning for connection layer deletion when justified godotengine/godot#97809
Restore arc_tolerance value when using Clipper2's InflatePaths godotengine/godot#98017
Revert unintentional rounding change when 2D transform snapping godotengine/godot#98195
Improve editor file dialog options godotengine/godot#99182
Fix removing last digit in spinbox while update_on_text_changed is true godotengine/godot#99721
Don't navigate to path when file is double-clicked godotengine/godot#100012
Correctly check time since shadow was allocated in atlas to avoid unnecessary re-allocations godotengine/godot#100064
Increase precision in linear_to_srgb() and srgb_to_linear() godotengine/godot#100659
Android: Fix Window size changes ignored when node is not in tree godotengine/godot#100746

Extra PRs:

(cherry picked from commit 9a84387)

(cherry picked from commit 5559075)

(cherry picked from commit 5cf9afb)

(cherry picked from commit b32395a)

…emoves sub properties (cherry picked from commit 27b7b43)

(cherry picked from commit 16f3d52)

…hen these are changed. (cherry picked from commit 94ad663)

(cherry picked from commit 250de08)

…rom_query()` My fault, I added a `get_space()` check for the other `GodotArea3D::remove_*_from_query()` but forgot about `soft_body`. (cherry picked from commit 2f515d6)

(cherry picked from commit 5aa8f8d)

(cherry picked from commit f2f34e9)

…in the same OBJ file that had UVs (cherry picked from commit 0754600)

Lifetime checks for stored `RIDs` for collision objects assumed they had valid `object_ids`. It turns out that some are not derived from `Object` and thus checking `ObjectDB` returns false for some valid `RIDs`. To account for this we only perform lifetime checks on valid `object_ids`. (cherry picked from commit 6764338)

(cherry picked from commit 0305e43)

(cherry picked from commit 56f0952)

(cherry picked from commit 6a9e50b)

(cherry picked from commit 36293a2)

(cherry picked from commit 6286f9d)

…tified (cherry picked from commit 975e7c8)

This was missed when upgrading from Clipper to Clipper2. (cherry picked from commit 9652695)

(cherry picked from commit 029045b)

(cherry picked from commit c170f1a)

(cherry picked from commit 8d3e9aa)

(cherry picked from commit 52889ab)

(cherry picked from commit 11bf2da)

(cherry picked from commit 7375fe2)

(cherry picked from commit 6e490da)

…ecessary re-allocations Co-authored-by: jitspoe <jitspoe@yahoo.com> (cherry picked from commit 1b5a15d)

This avoids the situation where white stops being white after conversion. While maintaining as much floating point ops as possible (cherry picked from commit 46ce499)

(cherry picked from commit c699d5b)

(cherry picked from commit 9f3067e)

Spartan322 added bug enhancement platform:android topic:core topic:gdscript topic:rendering topic:editor topic:porting usability topic:physics topic:input regression topic:gui topic:2d topic:animation topic:export performance topic:3d labels Jan 17, 2025

Spartan322 force-pushed the 4.3.1-cherry-pick/regressions branch from 1af5bc9 to 954b3cc Compare January 17, 2025 21:38

Norrox approved these changes Jan 17, 2025

View reviewed changes

Spartan322 force-pushed the 4.3.1-cherry-pick/regressions branch 2 times, most recently from 464a3ab to 6395726 Compare January 18, 2025 02:52

HolonProduction and others added 8 commits January 17, 2025 22:30

Autocompletion: Keep get_node values which are compatible with type hint

42c5681

(cherry picked from commit 9a84387)

Fix graph node sizing regression, improve blend tree contrast/margins

b7d3d62

(cherry picked from commit 5559075)

Don't fold resources when child of main inspector exits

922c3e0

(cherry picked from commit 5cf9afb)

Fix InputMap::event_get_index to handle unmatched events correctly

c370287

(cherry picked from commit b32395a)

Fix Inspector may scrolls away when editing a property that adds or r…

efc7a8c

…emoves sub properties (cherry picked from commit 27b7b43)

Fix EditorSpinSlider blocking viewport from getting focus

ad4d6e0

(cherry picked from commit 16f3d52)

[RTL] Expose missing default properties, ensure bbcode is reparserd w…

4711509

…hen these are changed. (cherry picked from commit 94ad663)

Fix RichTextLabel's modified stack being wiped on translation changes

8a5177b

(cherry picked from commit 250de08)

Rindbee and others added 23 commits January 17, 2025 22:30

Add forgotten get_space() check in `GodotArea3D::remove_soft_body_f…

9ce1221

…rom_query()` My fault, I added a `get_space()` check for the other `GodotArea3D::remove_*_from_query()` but forgot about `soft_body`. (cherry picked from commit 2f515d6)

Fix Undo/Redo not working in Bezier Animation Editor when moving keys

494548b

(cherry picked from commit 5aa8f8d)

Fix TabBar initialization issue and add tests

a87922e

(cherry picked from commit f2f34e9)

Fix crash when importing a surface with no UVs after another surface …

cce93e2

…in the same OBJ file that had UVs (cherry picked from commit 0754600)

Clean up two recently introduced WebGL errors

0646309

(cherry picked from commit 0305e43)

Fix editing of some properties in CodeHighlighter

de67044

(cherry picked from commit 56f0952)

Fix ItemList text trimming and autowrap margin

c996169

(cherry picked from commit 6a9e50b)

Fix renaming nodes on X11

0424460

(cherry picked from commit 36293a2)

GDScript: Fix GDScriptCache::get_full_script() uses non-remapped path

407e315

(cherry picked from commit 6286f9d)

[GraphEdit] Only print warning for connection layer deletion when jus…

e3fa70c

…tified (cherry picked from commit 975e7c8)

Restore arc_tolerance value when using Clipper2's InflatePaths

d4e026f

This was missed when upgrading from Clipper to Clipper2. (cherry picked from commit 9652695)

Account for physics interpolation and transform snapping when Y-sorting

7f678fd

(cherry picked from commit 029045b)

Don't recalculate final render transforms for Y-sorted canvas items

3ddb963

(cherry picked from commit c170f1a)

Revert incorrect rounding when 2D transform snapping

2b1e6c0

(cherry picked from commit 8d3e9aa)

[Scene] Add SceneStringName::toggled

d49e942

(cherry picked from commit 52889ab)

Improve editor file dialog options

e5f75f6

(cherry picked from commit 11bf2da)

Fix removing last digit in spinbox while update_on_text_changed is true

550d4a9

(cherry picked from commit 7375fe2)

Don't navigate to path when file is double-clicked

a784652

(cherry picked from commit 6e490da)

Correctly check time since shadow was allocated in atlas to avoid unn…

558f04c

…ecessary re-allocations Co-authored-by: jitspoe <jitspoe@yahoo.com> (cherry picked from commit 1b5a15d)

Increase precision in linear_to_srgb and srgb_to_linear

81159dc

This avoids the situation where white stops being white after conversion. While maintaining as much floating point ops as possible (cherry picked from commit 46ce499)

Fix root window size bug on Android

cba0e0b

(cherry picked from commit c699d5b)

Fix Window size changes ignored on Android

e642fb4

(cherry picked from commit 9f3067e)

Spartan322 force-pushed the 4.3.1-cherry-pick/regressions branch from 6395726 to e642fb4 Compare January 18, 2025 03:30

Spartan322 marked this pull request as ready for review January 18, 2025 03:31

tindrew approved these changes Jan 18, 2025

View reviewed changes

Spartan322 merged commit 0a44ed0 into Redot-Engine:4.3 Jan 18, 2025
18 checks passed

Spartan322 deleted the 4.3.1-cherry-pick/regressions branch January 18, 2025 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st regressions batch #929

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st regressions batch #929

Spartan322 commented Jan 17, 2025

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st regressions batch #929

[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st regressions batch #929

Conversation

Spartan322 commented Jan 17, 2025