Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root window size bug on Android #99669

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix root window size bug on Android #99669

merged 1 commit into from
Dec 2, 2024

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 marked this pull request as ready for review November 25, 2024 09:26
@syntaxerror247 syntaxerror247 requested a review from a team as a code owner November 25, 2024 09:26
@AThousandShips AThousandShips added bug platform:android topic:rendering topic:porting cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 25, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 25, 2024
@AThousandShips AThousandShips requested a review from a team November 25, 2024 10:06
m4gr3d
m4gr3d approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Is there a reason the logic is omitting TOOLS_ENABLED?

@syntaxerror247
Copy link
Member Author

syntaxerror247 commented Nov 30, 2024 •
edited
Loading

Is there a reason the logic is omitting TOOLS_ENABLED?

No specific reason, I was just unsure about it's affect on Android Editor, that's why i omitted it.
EDIT: Now, I think it would be okay to include that too 😅

akien-mga
akien-mga reviewed Dec 2, 2024
View reviewed changes
scene/main/window.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 302da3d into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@syntaxerror247 syntaxerror247 deleted the root_window_issues branch December 5, 2024 21:19
@Summersay415 Summersay415 mentioned this pull request Dec 22, 2024
Closed
@Summersay415
Copy link
Contributor

Summersay415 commented Dec 22, 2024 •
edited
Loading

This PR caused regression: #100743
I think this check should be moved to DisplayServer, or at least changed to (!get_parent() && is_inside_tree())

@syntaxerror247 syntaxerror247 mentioned this pull request Dec 22, 2024
Merged
@Sauermann
Copy link
Contributor

When this PR is cherrypicked, #100746 should also be cherrypicked.

@Spartan322 Spartan322 mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release platform:android topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Change window size at runtime will shrink viewport size in android
6 participants
@syntaxerror247 @akien-mga @Summersay415 @Sauermann @m4gr3d @AThousandShips