Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlendShapeTrack insertion not working #94738

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Fix BlendShapeTrack insertion not working #94738

merged 1 commit into from
Jul 26, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jul 25, 2024 •
edited
Loading

BlendShapeTrack was implemented in 4.0. The correct path format is Node3D:[BlendshapeName], not Node3D:blendshapes/[BlendshapeName].

image

The keying button on inspector also needs to be fixed, so I will follow up later.

@TokageItLab TokageItLab added bug topic:editor topic:animation topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 25, 2024
@TokageItLab TokageItLab added this to the 4.3 milestone Jul 25, 2024
@TokageItLab TokageItLab requested review from a team July 25, 2024 12:53
@TokageItLab TokageItLab force-pushed the blendshape-edit branch 3 times, most recently from 4f3ef1b to e2d6017 Compare July 25, 2024 13:01
@fire fire changed the title Fix BlendShapeTrack insertion totally not working Fix BlendShapeTrack insertion not working Jul 25, 2024
fire
fire approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be cherry picked when we've tested more.

@akien-mga akien-mga merged commit c7f862d into godotengine:master Jul 26, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi left review comments

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:animation topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

BlendShapeTrack insertion is not working
4 participants
@TokageItLab @akien-mga @fire @KoBeWi