AudioStreamPolyphonic: Implement stopping with sample playback #95321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Seems good enough! Thanks for your investigation, @akien-mga.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94724.
May not be complete, I didn't study the code for very long but I see a bunch of other flags like
pending_playthat may also need to be reset?It will also stop abruptly, while the stream playback seems to do a fade out IIUC.
@adamscott Feel free to take this over, I just did a quick investigation to try to find a workaround for 4.3. This could either be merged as is if you think it's good enough, or further improved by you, and/or merged as is with a new issue opened for what still needs to be improved for 4.4.