Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyphonic Audio Stream doesn't stop in HTML export in 4.3 beta (Sample playback type) #94724

Closed
tr-afa-ret opened this issue Jul 25, 2024 · 3 comments · Fixed by #95321
Closed

Comments

@tr-afa-ret
Copy link

Tested versions

  • Reproducable in 4.3 beta3 [82cedc8]

System information

Chrome and Edge on Windows, Chrome on Android

Issue description

stop_stream() method of AudioStreamPlaybackPolyphonic, doesn't stop audioStreams

Steps to reproduce

  • create a project in 4.3 beta3
  • add AudioStremPlayer
  • add AudioStreamPolyphonic as stream
  • through script use play_stream() to play and audiostream and add stream ID to a variable.
  • use stop_stream() with same stream ID to stop the audio stream

observe that the audio stream starts and stops when running from the editor
however the stream will not stop in HTML export

Minimal reproduction project (MRP)

polyphonichtmlproblem.zip

@akien-mga
Copy link
Member

This may be the same issue as #94226, in which case it would be fixed by #94268 (in upcoming 4.3.rc1).

@akien-mga
Copy link
Member

Doesn't seem fixed yet, I can confirm the bug in 4.3.rc2.

@akien-mga
Copy link
Member

I tested and confirm that the issue comes from Web audio now default to "Sample" playback type, which is new in 4.3.
Overriding it to "Stream" (i.e. like in 4.2.2) works around the issue.

image

@akien-mga akien-mga changed the title Polyphonic Audio Stream doesn't stop in HTML export in 4.3 beta Polyphonic Audio Stream doesn't stop in HTML export in 4.3 beta (Sample playback type) Aug 9, 2024
SlashScreen pushed a commit to SlashScreen/godot that referenced this issue Aug 12, 2024
TokisanGames pushed a commit to TokisanGames/godot that referenced this issue Aug 13, 2024
maidopi-usagi pushed a commit to maidopi-usagi/godot that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

3 participants