Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that OptimizedTranslation.generate() only works in editor #97284

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

timothyqiu
Copy link
Member

Closes #38935

This method has been editor-only since the open source of Godot.

Generating an OptimizedTranslation before adding a dynamically loaded translation file into the translation server would be a waste of time. Compressed messages have to be decompressed before they can be used anyway :P

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 21, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner September 21, 2024 15:27
@AThousandShips AThousandShips changed the title Document OptimizedTranslation.generate() only works in editor Document that OptimizedTranslation.generate() only works in editor Sep 21, 2024
@akien-mga akien-mga merged commit 2c1b8dd into godotengine:master Sep 23, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the optimized-translation-gen branch September 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A PHashTranslation generated and added at runtime works in editor run but not in exported projects
3 participants