-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor signal documentation to improve clarity. #97357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the issue reference from the commit message
Please squash your commits into one, see here |
This comment was marked as resolved.
This comment was marked as resolved.
You still need to squash your changes and push them with |
i am really sorry for all the trouble but i am really lost. 55262a6 (HEAD -> master, origin/master, origin/HEAD) Refactor signal documentation to improve clarity |
Because you included merge commits, you should rebase on to of You can also do:
And then fix the commit message and content |
There! Now everything is good! |
Thank you for all the help. It would have taken you 2 minutes to fix but instead you helped me fix it. |
We try to use all opportunities for learning even if it takes a bit longer, good work figuring it out, git can be a maze |
Thanks! And congrats for your first merged Godot contribution 🎉 |
added the description mentioned in #97221.
please let me know if any changes are needed.