Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem pool restore mem block cause slow creation #485

Merged
merged 16 commits into from
Dec 22, 2021
Merged

Fix mem pool restore mem block cause slow creation #485

merged 16 commits into from
Dec 22, 2021

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Dec 11, 2021

No description provided.

@zeroqn zeroqn requested a review from a team December 11, 2021 08:29
@zeroqn zeroqn force-pushed the fix-mem-pool-restore-mem-block-cause-slow-creation branch from 808c7af to ede901d Compare December 11, 2021 12:53
jjyr
jjyr reviewed Dec 12, 2021
View reviewed changes
crates/rpc-server/src/registry.rs Outdated Show resolved Hide resolved
crates/mem-pool/src/pool.rs Outdated Show resolved Hide resolved
crates/mem-pool/src/mem_block.rs Outdated Show resolved Hide resolved
crates/mem-pool/src/mem_block.rs Show resolved Hide resolved
@jjyr
Copy link
Collaborator

jjyr commented Dec 13, 2021

pls add some tests and send pr to develop branch

@zeroqn zeroqn force-pushed the fix-mem-pool-restore-mem-block-cause-slow-creation branch from ccd427c to 55a2428 Compare December 13, 2021 14:31
@zeroqn zeroqn changed the base branch from v0.7.x to develop December 13, 2021 14:32
@zeroqn
Copy link
Contributor Author

zeroqn commented Dec 13, 2021

pls add some tests and send pr to develop branch

Done

jjyr
jjyr requested changes Dec 20, 2021
View reviewed changes
crates/mem-pool/src/restore_manager.rs Outdated Show resolved Hide resolved
crates/rpc-server/src/registry.rs Show resolved Hide resolved
jjyr
jjyr previously approved these changes Dec 21, 2021
View reviewed changes
@jjyr jjyr requested a review from Flouse December 21, 2021 04:37
Flouse
Flouse previously approved these changes Dec 21, 2021
View reviewed changes
crates/types/src/offchain/extension.rs Outdated Show resolved Hide resolved
@zeroqn zeroqn dismissed stale reviews from Flouse and jjyr via d5a3d0c December 21, 2021 10:15
@zeroqn
fix(mem-pool): slow mem pool creation if restored mem block state not…
9ea1904 
… matched
@zeroqn
fix(mem-pool): deposits not restore from mem block
3a89d77
@zeroqn
refactor(mem-pool): always reset to re-generate mem pool state
bd5901a
@zeroqn
refactor(mem-pool): partial mem block dump
25a04dd
@zeroqn
fix(mem-pool): mem block txs not cleared after set pending list
2e2cf87
@zeroqn
refactor(mem-pool): reinject mem block tx log
b1d77f5
@zeroqn
refactor: base on reviews
91eda04
@zeroqn
refactor: base on reviews
cabddd2
@zeroqn
refactor(mem-pool): remove unused code
bf97e0e
@zeroqn
test(mem-pool): mem block dump and restore
556065d
@zeroqn
fix(mem-pool): pending deposits from restored mem block are skipped
3468480
@zeroqn
feat(mem-pool): only dump compact mem block
0c830f8
@zeroqn
fix(mem-pool): restored txs reverse in order
21fe3bc
@zeroqn
fix(mem-pool): restore from mem block failed
914656c 
fallback to packed::MemBlock
@zeroqn
fix typo
bc24fca
@zeroqn
rebase to develop
6100aca
@zeroqn zeroqn force-pushed the fix-mem-pool-restore-mem-block-cause-slow-creation branch from d5a3d0c to 6100aca Compare December 21, 2021 12:18
@jjyr jjyr requested a review from Flouse December 22, 2021 03:19
@jjyr jjyr merged commit 0acd433 into godwokenrises:develop Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@jjyr jjyr jjyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroqn @jjyr @Flouse