Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Questionable documentation and implementation of Equals #33

Closed
acln0 opened this issue Jul 19, 2018 · 0 comments
Closed

Questionable documentation and implementation of Equals #33

acln0 opened this issue Jul 19, 2018 · 0 comments

Comments

@acln0
Copy link
Member

acln0 commented Jul 19, 2018

The documentation for https://godoc.org/github.com/gofrs/uuid#Equal could be improved. While we're at it, perhaps the implementation could simply return u1 == u2.
theckman added a commit that referenced this issue Jul 19, 2018
@theckman
Improve Equal package function
2af6bef 
This change makes some improvements to the Equal package function:

- updates function comment to read better
- changes the argument variables to `a` and `b`, instead of `u1` and `u2`
- compare the arrays directly, instead of converting to slices and comparing

Fixes #33

Signed-off-by: Tim Heckman <t@heckman.io>
@theckman theckman mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acln0