Improve Equal package function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes some improvements to the Equal package function: - updates function comment to read better - changes the argument variables to `a` and `b`, instead of `u1` and `u2` - compare the arrays directly, instead of converting to slices and comparing Fixes #33 Signed-off-by: Tim Heckman <t@heckman.io>
acln0
approved these changes
Jul 19, 2018
2 similar comments
|
What happened with the 1.7 build? |
|
@acln0 looks like the runner ate it. Re-running that one. |
theckman
added a commit
that referenced
this pull request
Jul 19, 2018
Improve Equal package function Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes some improvements to the Equal package function:
aandb, instead ofu1andu2Fixes #33
Signed-off-by: Tim Heckman t@heckman.io