Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Equal package function #36

Merged
merged 1 commit into from
Jul 21, 2018
Merged

Deprecate the Equal package function #36

merged 1 commit into from
Jul 21, 2018

Conversation

theckman
Copy link
Member

This deprecates the Equal package function, in favor of consumers using the
== comparison operator themselves between two UUID values. Because the UUID
value is an array type, there is no reason for the helper function.

The intent is to remove this as part of a v2.x => v3.x release.

Fixes #35

Signed-off-by: Tim Heckman t@heckman.io

@theckman theckman requested review from zerkms and acln0 July 19, 2018 16:03
acln0
acln0 previously requested changes Jul 19, 2018
uuid.go Outdated
//
// Deprecated: this function is deprecated and will be removed in a future major
// version. The UUID type itself is directly comparable to another UUID value
// using `==`, meaning this function superfluous.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"meaning this function superfluous" does not sound quite right.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps more of the phrase can be simplified by saying "values of type UUID are comparable using ==".

@coveralls
Copy link

coveralls commented Jul 19, 2018

Pull Request Test Coverage Report for Build 103

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 99.063%

Totals Coverage Status
Change from base Build 97: -0.9%
Covered Lines: 317
Relevant Lines: 320

💛 - Coveralls

@theckman
Copy link
Member Author

I'm going to be traveling over the coming week, leaving tomorrow morning (~9 hours). I'll try to either get the commit amended in the airport, or after I get to my hotel.

This deprecates the `Equal` package function, in favor of consumers using the
`==` comparison operator themselves between two `UUID` values. Because the UUID
value is an array type, there is no reason for the helper function.

The intent is to remove this as part of a v2.x => v3.x release.

Fixes #35

Signed-off-by: Tim Heckman <t@heckman.io>
@theckman
Copy link
Member Author

Commit amended and pushed.

@theckman theckman dismissed acln0’s stale review July 21, 2018 04:48

Pushed change to address this review.

@theckman theckman requested a review from acln0 July 21, 2018 04:48
Copy link
Member

@acln0 acln0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@theckman theckman merged commit da76c80 into master Jul 21, 2018
theckman added a commit that referenced this pull request Jul 21, 2018
Deprecate the Equal package function

Signed-off-by: Tim Heckman <t@heckman.io>
@zerkms zerkms mentioned this pull request Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants