-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the Equal package function #36
Conversation
uuid.go
Outdated
// | ||
// Deprecated: this function is deprecated and will be removed in a future major | ||
// version. The UUID type itself is directly comparable to another UUID value | ||
// using `==`, meaning this function superfluous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"meaning this function superfluous" does not sound quite right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps more of the phrase can be simplified by saying "values of type UUID are comparable using ==".
I'm going to be traveling over the coming week, leaving tomorrow morning (~9 hours). I'll try to either get the commit amended in the airport, or after I get to my hotel. |
This deprecates the `Equal` package function, in favor of consumers using the `==` comparison operator themselves between two `UUID` values. Because the UUID value is an array type, there is no reason for the helper function. The intent is to remove this as part of a v2.x => v3.x release. Fixes #35 Signed-off-by: Tim Heckman <t@heckman.io>
2f1431f
to
da76c80
Compare
Commit amended and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Deprecate the Equal package function Signed-off-by: Tim Heckman <t@heckman.io>
This deprecates the
Equal
package function, in favor of consumers using the==
comparison operator themselves between twoUUID
values. Because the UUIDvalue is an array type, there is no reason for the helper function.
The intent is to remove this as part of a v2.x => v3.x release.
Fixes #35
Signed-off-by: Tim Heckman t@heckman.io