Adds Compare and UUID.Equals functions #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2019 14:01
Adds a Compare and UUID.Equal functions: Compare takes two UUID's and returns -1 if the first UUID is lexically before the second, 0 if they are equal, and 1 if the first UUID is lexically after the second. This implementation follows RFC 4122 section 4.5 where equality and order checks should be done by converting the UUID to a unsigned 128-bit integer and compared. Tests included.
Adds a Compare and UUID.Equal functions: Compare takes two UUID's and returns -1 if the first UUID is lexically before the second, 0 if they are equal, and 1 if the first UUID is lexically after the second. This implementation follows RFC 4122 section 4.5 where equality and order checks should be done by converting the UUID to a unsigned 128-bit integer and compared. Tests included.
|
Equal used to be here, but was removed because you can just use the |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 99.05% 99.09% +0.03%
==========================================
Files 4 4
Lines 318 330 +12
==========================================
+ Hits 315 327 +12
Misses 2 2
Partials 1 1
Continue to review full report at Codecov.
|
|
Also, comparing UUIDs should just be |
|
@jadr2ddude thanks for responding! You make good points, my attempt to follow the RFC clouded more obvious solutions like feel free to close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I didn't see a section on contributions, I hope I'm not overstepping with this proposal.
This change adds two functions, a
Compare(UUID, UUID) int, and UUID attachedUUID.Equal(UUID) bool:Compare takes two UUID's and returns -1 if the first UUID is lexically before the second, 0 if they are equal, and 1 if the first UUID is lexically after the second.
Equal takes a single UUID and compares to the attached returning true if they are equal and false if not. Equal makes use of Compare.
This implementation follows RFC 4122 where equality and order checks should be done by converting the UUID to a unsigned 128-bit integer and compared.
Tests included
Cheers!
Jon