Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue struct attribute converting when has no json name but with omitempty tag #2486

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Mar 3, 2023

No description provided.

@gqcn gqcn added the bug It is confirmed a bug, but don't worry, we'll handle it. label Mar 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (34946f6) 79.96% compared to head (5201ede) 79.98%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2486      +/-   ##
==========================================
+ Coverage   79.96%   79.98%   +0.01%     
==========================================
  Files         598      599       +1     
  Lines       49570    49792     +222     
==========================================
+ Hits        39641    39826     +185     
- Misses       7984     8008      +24     
- Partials     1945     1958      +13     
Flag Coverage Δ
go-1.15-386 80.01% <100.00%> (-0.03%) ⬇️
go-1.15-amd64 80.02% <100.00%> (?)
go-1.16-386 80.04% <100.00%> (+0.02%) ⬆️
go-1.16-amd64 80.03% <100.00%> (+0.04%) ⬆️
go-1.17-amd64 80.02% <100.00%> (?)
go-1.18-386 79.95% <100.00%> (+0.02%) ⬆️
go-1.18-amd64 79.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/gconv/gconv_map.go 97.08% <100.00%> (+0.02%) ⬆️
contrib/drivers/oracle/oracle.go 79.45% <0.00%> (ø)
contrib/registry/zookeeper/zookeeper_watcher.go 51.11% <0.00%> (+2.22%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (+5.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 13f6fb1 into master Mar 7, 2023
@gqcn gqcn deleted the fix/gconv-map branch March 7, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It is confirmed a bug, but don't worry, we'll handle it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants