Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue struct attribute converting when has no json name but with omitempty tag #2486

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix issue struct attribute converting when has no json name but with omitempty tag #2486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions util/gconv/gconv_map.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,9 @@ func doMapConvertForMapOrStructValue(in doMapConvertForMapOrStructValueInput) in
mapKey = strings.TrimSpace(array[0])
}
}
if mapKey == "" {
mapKey = fieldName
}
}
if in.RecursiveOption || rtField.Anonymous {
// Do map converting recursively.
Expand Down
14 changes: 14 additions & 0 deletions util/gconv/gconv_z_unit_map_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,3 +606,17 @@ func TestMapsDeep(t *testing.T) {
t.Assert(list[1]["id"], 200)
})
}

func TestMapWithJsonOmitEmpty(t *testing.T) {
gtest.C(t, func(t *gtest.T) {
type S struct {
Key string `json:",omitempty"`
Value interface{} `json:",omitempty"`
}
s := S{
Key: "",
Value: 1,
}
t.Assert(gconv.Map(s), g.Map{"Value": 1})
})
}