Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace python script with node script for portal Dockerfile #18635

Merged
merged 1 commit into from
May 4, 2023
Merged

Replace python script with node script for portal Dockerfile #18635

merged 1 commit into from
May 4, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 4, 2023 •
edited
Loading

  1. Use node script to convert swagger.yaml to swagger.json

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner May 4, 2023 08:05
@AllForNothing AllForNothing added the release-note/infra Infra related changes e.g. release, test, ship etc... label May 4, 2023
@AllForNothing AllForNothing requested review from wy65701436 and chlins May 4, 2023 08:06
Replace python script with node script for portal Dockerfile
a3ef08b 
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing requested a review from stonezdj May 4, 2023 08:10
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #18635 (a3ef08b) into main (362387f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18635      +/-   ##
==========================================
+ Coverage   67.37%   67.40%   +0.02%     
==========================================
  Files         984      984              
  Lines      107029   107029              
  Branches     2670     2670              
==========================================
+ Hits        72116    72139      +23     
+ Misses      31031    31012      -19     
+ Partials     3882     3878       -4
Flag Coverage Δ
unittests 67.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

chlins
chlins approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 0a3509f into goharbor:main May 4, 2023
@AllForNothing AllForNothing mentioned this pull request May 5, 2023
Merged
5 tasks
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
@AllForNothing @WilfredAlmeida
Replace python script with node script for portal Dockerfile (goharbo…
e8f919b 
…r#18635)

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees

@AllForNothing AllForNothing

Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllForNothing @stonezdj @chlins @zyyw @MinerYang