Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick]Replace python script with node script for portal Dockerfile #18641

Merged
merged 2 commits into from
May 8, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented May 5, 2023

1.Cherry-pick #18635

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #18641 (7d3d55e) into release-1.10.0 (3069231) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.0   #18641      +/-   ##
==================================================
+ Coverage           55.98%   56.00%   +0.01%     
==================================================
  Files                 612      612              
  Lines               32467    32460       -7     
  Branches              825      825              
==================================================
+ Hits                18177    18179       +2     
+ Misses              11491    11482       -9     
  Partials             2799     2799              
Flag Coverage Δ
unittests 56.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@AllForNothing AllForNothing merged commit 1e616ad into goharbor:release-1.10.0 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants