Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security hub summary API #18872

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jun 30, 2023

include with_dangerous_artifact, with_dangerous_cve option

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner June 30, 2023 07:07
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jun 30, 2023
@stonezdj stonezdj assigned wy65701436 and chlins and unassigned zyyw, OrlinVasilev and MinerYang Jun 30, 2023
@stonezdj stonezdj requested review from chlins and wy65701436 June 30, 2023 07:08
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #18872 (294aa3d) into main (df4dc3c) will decrease coverage by 22.65%.
The diff coverage is n/a.

❗ Current head 294aa3d differs from pull request most recent head d094e48. Consider uploading reports for the commit d094e48 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18872       +/-   ##
===========================================
- Coverage   67.33%   44.68%   -22.65%     
===========================================
  Files         981      236      -745     
  Lines      107342    13178    -94164     
  Branches     2698     2698               
===========================================
- Hits        72282     5889    -66393     
+ Misses      31176     6994    -24182     
+ Partials     3884      295     -3589     
Flag Coverage Δ
unittests 44.68% <ø> (-22.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 748 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch 2 times, most recently from 2e38db0 to f2e4562 Compare July 2, 2023 03:09
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch 7 times, most recently from 5cf3b8d to f5d11ca Compare July 8, 2023 03:15
@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch from f5d11ca to 015a437 Compare July 10, 2023 06:11
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch 2 times, most recently from 699c323 to 661b103 Compare July 11, 2023 09:58
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch 3 times, most recently from 250779e to e7f7673 Compare July 12, 2023 08:01
  include WithCVE, WithArtifact option

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23jun13_add_cve_summary branch from e7f7673 to d094e48 Compare July 12, 2023 09:51
@stonezdj stonezdj merged commit 93e428d into goharbor:main Jul 12, 2023
@AllForNothing AllForNothing mentioned this pull request Jul 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants