Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Hub UI #18942

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Add Security Hub UI #18942

merged 1 commit into from
Jul 20, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 17, 2023

1.Fixes #18819
2.Add Security Hub page as a new tab for Interrogation Services

Backend APIs: #18924,#18872

Proposal: goharbor/community#228
UI changes:
image
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner July 17, 2023 12:47
@AllForNothing AllForNothing added the release-note/new-feature New Harbor Feature label Jul 17, 2023
@AllForNothing AllForNothing force-pushed the cve-database branch 3 times, most recently from b4ece4d to c1db104 Compare July 18, 2023 09:01
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing force-pushed the cve-database branch 2 times, most recently from 8758a35 to cde74fa Compare July 19, 2023 10:31
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #18942 (eb16a8b) into main (b08dce4) will decrease coverage by 0.06%.
The diff coverage is 52.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18942      +/-   ##
==========================================
- Coverage   67.46%   67.41%   -0.06%     
==========================================
  Files         986      994       +8     
  Lines      108630   108825     +195     
  Branches     2702     2747      +45     
==========================================
+ Hits        73288    73362      +74     
- Misses      31411    31524     +113     
- Partials     3931     3939       +8     
Flag Coverage Δ
unittests 67.41% <52.91%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/app/base/harbor-shell/harbor-shell.component.ts 75.86% <0.00%> (-1.34%) ⬇️
src/portal/src/app/shared/shared.module.ts 100.00% <ø> (ø)
...bility-database/single-bar/single-bar.component.ts 14.28% <14.28%> (ø)
...erability-filter/vulnerability-filter.component.ts 25.00% <25.00%> (ø)
...s/vulnerability-database/security-hub.component.ts 51.56% <51.56%> (ø)
...hared/directives/scroll/scroll-anchor.directive.ts 66.66% <66.66%> (ø)
...ability-summary/vulnerability-summary.component.ts 68.57% <68.57%> (ø)
...s/vulnerability-database/security-hub.interface.ts 76.92% <76.92%> (ø)
...shared/directives/scroll/scroll-manager.service.ts 80.00% <80.00%> (ø)
...ared/directives/scroll/scroll-section.directive.ts 83.33% <83.33%> (ø)
... and 5 more

... and 6 files with indirect coverage changes

1.Fixes goharbor#18819
2.Add Security Hub page as a new tab for Interrogation Services

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 73533d8 into goharbor:main Jul 20, 2023
MinerYang pushed a commit that referenced this pull request Jul 24, 2023
1.Fixes #18819
2.Add Security Hub page as a new tab for Interrogation Services

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI to display the summary and search the CVE
6 participants