enable notary v2 policy checker #18927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18927 +/- ##
==========================================
+ Coverage 67.40% 70.57% +3.16%
==========================================
Files 986 750 -236
Lines 107983 94816 -13167
Branches 2698 0 -2698
==========================================
- Hits 72786 66912 -5874
+ Misses 31300 24299 -7001
+ Partials 3897 3605 -292
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wy65701436
force-pushed
the
notaryv2
branch
3 times, most recently
from
958b985 to
7567e68
Compare
zyyw
reviewed
Jul 14, 2023
| @@ -44,42 +43,56 @@ func Cosign() func(http.Handler) http.Handler { | |||
| return err | |||
| } | |||
|
|
|||
| // If cosign policy enabled, it has to at least have one cosign signature. | |||
| // If signature policy enabled, it has to at least have one cosign signature. | |||
There was a problem hiding this comment.
"If signature policy enabled, it has to at least have one
cosign signature. "
The cosign signature statement here in the comment seems to be not correct/accurate.
add notary v2 pull policy, when it enables, the artifact cannot be pull without the notation signature. Signed-off-by: wang yan <wangyan@vmware.com>
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this pull request
Jul 19, 2023
1. for goharbor#18927 Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this pull request
Jul 19, 2023
1. for goharbor#18927 Signed-off-by: AllForNothing <sshijun@vmware.com>
5 tasks
AllForNothing
pushed a commit
to AllForNothing/harbor
that referenced
this pull request
Jul 19, 2023
1. for goharbor#18927 Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
added a commit
that referenced
this pull request
Jul 19, 2023
1. for #18927 Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add notary v2 pull policy, when it enables, the artifact cannot be pull without the notation signature.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: