Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notation UI for deployment security #18952

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 19, 2023

  1. for enable notary v2 policy checker #18927
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. for goharbor#18927

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #18952 (92b7cc6) into main (970bdab) will increase coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18952      +/-   ##
==========================================
+ Coverage   67.42%   67.45%   +0.03%     
==========================================
  Files         986      986              
  Lines      108614   108630      +16     
  Branches     2698     2702       +4     
==========================================
+ Hits        73229    73274      +45     
+ Misses      31452    31424      -28     
+ Partials     3933     3932       -1     
Flag Coverage Δ
unittests 67.45% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ct-list-tab/pull-command/pull-command.component.ts 12.50% <ø> (ø)
...se/project/repository/artifact/artifact.service.ts 60.00% <66.66%> (-1.12%) ⬇️
...t-tab/sub-accessories/sub-accessories.component.ts 76.66% <85.71%> (+0.74%) ⬆️
...t/artifact-list-tab/artifact-list-tab.component.ts 42.82% <90.90%> (+0.74%) ⬆️
...t-policy-config/project-policy-config.component.ts 48.75% <100.00%> (+0.32%) ⬆️
...c/app/base/project/repository/artifact/artifact.ts 55.55% <100.00%> (+1.01%) ⬆️
...al/src/app/services/event-service/event.service.ts 78.94% <100.00%> (+0.56%) ⬆️

... and 8 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 79e8c39 into goharbor:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants