Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap filenames in quotes only for Windows CMD #1371

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Wrap filenames in quotes only for Windows CMD #1371

merged 1 commit into from
Aug 7, 2023

Conversation

joelim-work
Copy link
Collaborator

Filenames are wrapped in quotes when exporting them as environment variables to deal with Windows CMD, although it causes issues with PowerShell. Logic is added to check if the shell is cmd or not, similar to

lf/os_windows.go

Lines 104 to 105 in 2620f49

// Windows CMD requires special handling to deal with quoted arguments
if strings.ToLower(gOpts.shell) == "cmd" {

@joelim-work joelim-work merged commit 1c52e3a into gokcehan:master Aug 7, 2023
@joelim-work joelim-work deleted the fix-filename-quoting branch August 7, 2023 07:56
@tayopi tayopi mentioned this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting 'map e $nvim $Env:f' does not work for shell pwsh
1 participant