Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap filenames in quotes only for Windows CMD #1371

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Wrap filenames in quotes only for Windows CMD #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion os_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,9 @@ func errCrossDevice(err error) bool {
}

func quoteString(s string) string {
return fmt.Sprintf(`"%s"`, s)
// Windows CMD requires special handling to deal with quoted arguments
if strings.ToLower(gOpts.shell) == "cmd" {
return fmt.Sprintf(`"%s"`, s)
}
return s
}