Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: opening an existing file with O_CREATE|O_TRUNC and permission 0 changes file to be read-only on Windows [1.14 backport] #39158

Closed
gopherbot opened this issue May 20, 2020 · 2 comments
Closed

os: opening an existing file with O_CREATE|O_TRUNC and permission 0 changes file to be read-only on Windows [1.14 backport] #39158

gopherbot opened this issue May 20, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.4

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #38225 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open a backport to 1.14. This is a regression that was introduced in 1.14.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 20, 2020
@gopherbot gopherbot mentioned this issue May 20, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.4 milestone May 20, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/234686 mentions this issue: [release-branch.go1.14] syscall: preserve Windows file permissions for O_CREAT|O_TRUNC

@gopherbot
Copy link
Contributor Author

Closed by merging f758dab to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue May 23, 2020
@ianlancetaylor
[release-branch.go1.14] syscall: preserve Windows file permissions fo…
f758dab 
…r O_CREAT|O_TRUNC

On Windows, calling syscall.Open(file, O_CREAT|O_TRUNC, 0) for a file
that already exists would change the file to be read-only.
That is not how the Unix syscall.Open behaves, so avoid it on
Windows by calling CreateFile twice if necessary.

For #38225
Fixes #39158

Change-Id: I70097fca8863df427cc8a97b9376a9ffc69c6318
Reviewed-on: https://go-review.googlesource.com/c/go/+/234534
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
(cherry picked from commit 567556d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/234686
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jun 1, 2020
@mildwonkey mildwonkey mentioned this issue Aug 25, 2020
Merged
@golang golang locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.4
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot