Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use go 1.14.7 #25992

Merged
merged 1 commit into from
Aug 25, 2020
Merged

build: Use go 1.14.7 #25992

merged 1 commit into from
Aug 25, 2020

Conversation

alisdair
Copy link
Contributor

From the go release notes:

  • go1.14.3 (released 2020/05/14) includes fixes to cgo, the compiler, the runtime, and the go/doc and math/big packages.
  • go1.14.4 (released 2020/06/01) includes fixes to the go doc command, the runtime, and the encoding/json and os packages.
  • go1.14.5 (released 2020/07/14) includes security fixes to the crypto/x509 and net/http packages.
  • go1.14.6 (released 2020/07/16) includes fixes to the go command, the compiler, the linker, vet, and the database/sql, encoding/json, net/http, reflect, and testing packages.
  • go1.14.7 (released 2020/08/06) includes security fixes to the encoding/binary package.

From the go release notes:

go1.14.3 (released 2020/05/14) includes fixes to cgo, the compiler, the
runtime, and the go/doc and math/big packages.

go1.14.4 (released 2020/06/01) includes fixes to the go doc command, the
runtime, and the encoding/json and os packages.

go1.14.5 (released 2020/07/14) includes security fixes to the
crypto/x509 and net/http packages.

go1.14.6 (released 2020/07/16) includes fixes to the go command, the
compiler, the linker, vet, and the database/sql, encoding/json,
net/http, reflect, and testing packages.

go1.14.7 (released 2020/08/06) includes security fixes to the
encoding/binary package.

https://golang.org/doc/devel/release.html#go1.14.minor
@alisdair alisdair added the build Auto-pinning label Aug 25, 2020
@alisdair alisdair requested a review from a team August 25, 2020 16:39
@alisdair alisdair self-assigned this Aug 25, 2020
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #25992 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
dag/marshal.go 53.33% <0.00%> (-1.12%) ⬇️
backend/remote/backend_common.go 54.57% <0.00%> (-0.68%) ⬇️
states/statefile/version4.go 57.83% <0.00%> (+0.28%) ⬆️
terraform/node_resource_plan.go 93.44% <0.00%> (+1.63%) ⬆️

Copy link
Contributor

@pselle pselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm into this but I'd like another team member to also +1 -- having a day to kick the tires here sounds good to me, but that may not be universal.

@mildwonkey
Copy link
Contributor

Thanks for the link to the release notes! I noticed this interesting windows file permission issue; we might (crosses fingers) have an open issue or two that are fixed by this version bump!

@alisdair
Copy link
Contributor Author

image

e2e tests on Windows 10 are passing.

@alisdair alisdair merged commit d22a2cd into master Aug 25, 2020
@alisdair alisdair deleted the alisdair/upgrade-go branch August 25, 2020 19:11
@ghost
Copy link

ghost commented Oct 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Auto-pinning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants