Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: finalizer call has wrong frame size [1.17 backport] #51458

Closed
gopherbot opened this issue Mar 3, 2022 · 3 comments
Closed

runtime: finalizer call has wrong frame size [1.17 backport] #51458

gopherbot opened this issue Mar 3, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.9

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #51457 to be considered for backport to the next 1.17 minor release.

@gopherbot please backport this to Go 1.17 release. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 3, 2022
@gopherbot gopherbot mentioned this issue Mar 3, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.9 milestone Mar 3, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/389794 mentions this issue: [release-branch.go1.17] runtime: count spill slot for frame size at finalizer call

@jeremyfaller jeremyfaller added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 9, 2022
@jeremyfaller
Copy link
Contributor

jeremyfaller commented Mar 9, 2022 •
edited
Loading

Approving as a serious issue without a workaround. Only Go 1.17 needs this backport.

@gopherbot
Copy link
Contributor Author

Closed by merging 88be85f to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Mar 14, 2022
@cherrymui @heschi
[release-branch.go1.17] runtime: count spill slot for frame size at f…
88be85f 
…inalizer call

The finalizer is called using reflectcall. When register ABI is
used, the finalizer's argument is passed in register(s). But the
frame size calculation does not include the spill slot. When the
argument actually spills, it may clobber the caller's stack frame.
This CL fixes it.

Updates #51457.
Fixes #51458.

Change-Id: Ibcc7507c518ba65c1c5a7759e5cab0ae3fc7efce
Reviewed-on: https://go-review.googlesource.com/c/go/+/389574
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 58804ea)
Reviewed-on: https://go-review.googlesource.com/c/go/+/389794
@FZambia FZambia mentioned this issue Apr 28, 2022
Closed
@knz knz mentioned this issue May 25, 2022
Closed
@golang golang locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.9
Development

No branches or pull requests
2 participants
@jeremyfaller @gopherbot