build: upgrade to latest go 1.17 #81839
Labels
A-build-system
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-dev-inf
Comments
knz
added
C-bug
craig bot
pushed a commit
that referenced
this issue
May 26, 2022
81739: ccl: Fill in chart catalog with missed metrics r=koorosh a=koorosh Based on PR: #81038 Resolves: #81359 This change adds missing metrics to the chart catalog. 81753: bazel: use `exec_tools` in `pkg/sql/sem/tree/BUILD.bazel`, not `tools` r=rail a=rickystewart Release note: None 81760: bazel: add custom `shadow` lint r=rail a=rickystewart We explicitly ignore variables named `err`, `pErr`, and `ctx`. Closes #73069. Release note: None 81849: *: upgrade golang to 1.17.10 r=rail a=rickystewart * [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Download ALL the archives (`.tar.gz`, `.zip`) for the new Go version from https://golang.org/dl/ and mirror them in the `public-bazel-artifacts` bucket in the `Bazel artifacts` project in GCP (sub-directory `go`, next to the other Go SDK's). * [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you mirrored in the step above. * [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch `@distdir//:archives`` to ensure you've updated all hashes to the correct value. * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) I also tweaked `bootstrap-debian.sh` to additionally install `libresolv-wrapper`, which fixes an issue with building w/ pre-built `c-deps` in `--config=dev`. Closes #81839. Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the build uses 1.17.6.
Patches for the following issues are included in 1.17.10 and likely affect CockroachDB:
v2.…+incompatibleversion when av2/go.modfile exists [1.17 backport] golang/go#51332Jira issue: CRDB-16090
The text was updated successfully, but these errors were encountered: