Skip to content

misc/cgo/testsanitizers: deadlock in TestTSAN/tsan11 #53113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue May 27, 2022 · 5 comments
Closed

misc/cgo/testsanitizers: deadlock in TestTSAN/tsan11 #53113

bcmills opened this issue May 27, 2022 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented May 27, 2022

https://build.golang.org/log/6cd850061b3c63c3393144d832c7e47ac50bd8b5

##### ../misc/cgo/testsanitizers
--- FAIL: TestTSAN (13.27s)
    --- FAIL: TestTSAN/tsan11 (256.31s)
        tsan_test.go:53: /tmp/workdir-host-linux-amd64-wsl/tmp/TestTSAN4253803927/tsan11 exited with exit status 2
            SIGQUIT: quit
            PC=0x512ea3 m=0 sigcode=0

Looks like another unbuffered channel passed to signal.Notify (as in #52998).
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels May 27, 2022
@bcmills bcmills added this to the Go1.19 milestone May 27, 2022
@bcmills bcmills self-assigned this May 27, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/409094 mentions this issue: misc/cgo/testsanitizers: buffer the signal channel in TestTSAN/tsan11

@bcmills bcmills changed the title misc/cgo/testsanitizers: timeout in TestTSAN/tsan11 misc/cgo/testsanitizers: deadlock in TestTSAN/tsan11 May 27, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 27, 2022

@gopherbot, please backport to Go 1.18 and 1.17. This is a test-only fix for a spurious deadlock.

This was referenced May 27, 2022
Closed
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #53114 (for 1.17), #53115 (for 1.18).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/408823 mentions this issue: [release-branch.go1.18] misc/cgo/testsanitizers: buffer the signal channel in TestTSAN/tsan11

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/408824 mentions this issue: [release-branch.go1.17] misc/cgo/testsanitizers: buffer the signal channel in TestTSAN/tsan11

@bcmills bcmills mentioned this issue May 27, 2022
Closed
gopherbot pushed a commit that referenced this issue May 30, 2022
@dmitshur
[release-branch.go1.18] misc/cgo/testsanitizers: buffer the signal ch…
da608a2 
…annel in TestTSAN/tsan11

This fix is analogous to the one in CL 407888.

'go vet' catches the error, but it is not run on this file because the
file is (only) compiled when running testsanitizers/TestTSAN.

Fixes #53115.
Updates #53113.

Change-Id: I74f7b7390a9775ff00a06214c1019ba28846dd11
Reviewed-on: https://go-review.googlesource.com/c/go/+/409094
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
(cherry picked from commit 0f57c88)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408823
Reviewed-by: Ian Lance Taylor <iant@google.com>
gopherbot pushed a commit that referenced this issue May 30, 2022
@dmitshur
[release-branch.go1.17] misc/cgo/testsanitizers: buffer the signal ch…
909881d 
…annel in TestTSAN/tsan11

This fix is analogous to the one in CL 407888.

'go vet' catches the error, but it is not run on this file because the
file is (only) compiled when running testsanitizers/TestTSAN.

Fixes #53114.
Updates #53113.

Change-Id: I74f7b7390a9775ff00a06214c1019ba28846dd11
Reviewed-on: https://go-review.googlesource.com/c/go/+/409094
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
(cherry picked from commit 0f57c88)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408824
Reviewed-by: Ian Lance Taylor <iant@google.com>
@rsc rsc unassigned bcmills Jun 22, 2022
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot