Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: remove the experimentalWatchedFileDelay setting #55332

Closed
findleyr opened this issue Sep 22, 2022 · 2 comments
Closed

x/tools/gopls: remove the experimentalWatchedFileDelay setting #55332

findleyr opened this issue Sep 22, 2022 · 2 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

A follow-up to #55268, this issue tracks removal of the "experimentalWatchedFileDelay" setting.
@findleyr findleyr added this to the gopls/v0.11.0 milestone Sep 22, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 22, 2022
@hyangah hyangah mentioned this issue Sep 29, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/462496 mentions this issue: gopls/internal/lsp: remove the experimentalWatchedFileDelay setting

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/462595 mentions this issue: gopls/internal/lsp: remove Server.processModifications

gopherbot pushed a commit to golang/tools that referenced this issue Jan 23, 2023
@findleyr
gopls/internal/lsp: remove Server.processModifications
f269f53 
Now that we no longer support a process delay, there is no need for this
function. Also, clean up the logic to await the completion of change
processing.

Updates golang/go#55332

Change-Id: I27936e112ee872eb1a46b350bf6f8f867a83bf19
Reviewed-on: https://go-review.googlesource.com/c/tools/+/462595
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
@findleyr findleyr self-assigned this Jan 23, 2023
@golang golang locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr